Hi people,
Thanks for reviewing my package.
Op za, 01-07-2006 te 04:04 -0500, schreef John Goerzen:
You have a bashism in debian/rules:
cp -f /usr/share/misc/config.{sub,guess} . cp: cannot stat `/usr/share/misc/config.{sub,guess}': No such file or directory make: *** [config.status] Error 1 debuild: fatal error at line 1224: debian/rules build failed
It will likely not pass all autobuilders until this is corrected.
en op za, 01-07-2006 te 12:33 +0300, schreef Kari Pahula:
Looks solid. However, one thing:
c2hs (0.14.5-1) unstable; urgency=low - move groff and linuxdoc-tools to Build-Depends-Indep.
The buildds will call debian/rules build, even though they're only building architecture dependent packages. Specifically they won't install Build-Depends-Indep. Your current debian/rules will fail with dpkg-buildpackage -B when Build-Depends-Indep remain uninstalled.
I fixed both issues and uploaded -3 to my homepage [1]. It is lintian and linda clean should now build on buildds (I have tested this with pdebuild --debbuildopts -B -- --binary-arch)
The packages is downloadable by doing:
dget http://moonshine.dnsalias.org/debian/unstable/c2hs_0.14.5-3_i386.changes
If one wants to rebuild and upload this, don't forget the dpkg-buildpackage flags "-sa -v0.13.6-5" to include the complete changelog and source.
Greetings Arjan
[1] http://moonshine.dnsalias.org/debian/unstable
c2hs (0.14.5-3) unstable; urgency=low . * Fix broken debian/rules: - Let build only depend on binary-arch as dpkg-buildpackage (and thus the buildds) will call build even when it is only building the architecture dependent packages. (thanks Kari Pahula) - Fix bashism. (thanks John Goerzen) . c2hs (0.14.5-2) unstable; urgency=low . * Update package for ghc6 version 6.4.2. * debian/control.in: - remove libghc6-cabal-dev from Build-Depends. - add ghc6 (>= 6.4.2) to Build-Depends to get Cabal version >= 1.1.4. - add ppc64 to Architectures as ghc6 is now available on ppc64. * debian/patches/01_update-manpage.dpatch: updated. Fix typo. * debian/patches/06_fix-Setup-for-ghc-6.4.2.dpatch: added. Replace Setup.hs with version from upstream VCS to fix build with ghc 6.4.2. . c2hs (0.14.5-1) unstable; urgency=low . * New upstream release. Closes: #372836 - no longer ships a library for ghc6. * New maintainer. Closes: #342801 * debian/c2hs-doc.doc-base: change section to Apps/Programming. * added debian/control.in - drop the libghc6-c2hs-dev package. - use $ghc6_app_bdeps, $ghc6_arches substitution variables from update-haskell-control to get the build dependency on ghc6 and architecture list for c2hs. - replace ${Source-Version} with ${binary:Version} and ${source:Version} to make the package binNMU safe. - add build dependency on dpkg-dev (>= 1.13.19) which introduces ${binary:Version} and ${source:Version}. - move groff and linuxdoc-tools to Build-Depends-Indep. * debian/copyright: add copyright notice for the manual which is licensed under the GNU Free Document License. * debian/patches/*: remove old patches and change to dpatch. * debian/rules: change from cdbs to debhelper. * debian/watch: upgrade to format version 3.